Implement computation of verification shares #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to allow for external/manual serialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks a lot for your implementation!
I've built a networking layer for it so that the participants can run on different machines. This PR contains the adjustments which were needed for me to use this library.
Overview:
Implement the function to compute a participant's
IndividualPublicKeyafter DKG.It uses the equation from the paper but is relatively slow.
Public fields instead of
serdesupportI simply assumed you would prefer to keep the serialization
derives out of the code until it is more stable.-> Instead of adding serde, I just made the fields public so that API consumers can do this on their own.
An open question here is whether the API should require consumers to always transmit the participant's index or not. The index is just redundant info given the fact that you have to use an authenticated channel anyways (at least for some messages).
The default features expose
ed25519-dalekbut this was not declared as dependency, leading to a dependency errorThis is the first time for me using Rust; please let me know what you think.