Add URI to various vocabulary JSON fields #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number of JSON fields contain the value of a vocabulary. This change adds a field alongside (usually fieldURI) that contains the fully-qualified URI to the vocabulary item.
|
There is a helper function in #36 that I'd like to use in this, so that should get merged first or we should combine the two. |
|
@MatthewWilkes did you mean the helper function is in #37 ? |
|
Blocked for #37 |
|
That's right, that would clean this up a bit to have it available. |
|
Review requested from @cguardia per discussion with @skleinfeldt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of JSON fields contain the value of a vocabulary. This change
adds a field alongside (usually fieldURI) that contains the fully-qualified
URI to the vocabulary item.
This PR fixes isawnyu/pleiades-gazetteer#367
NB: This is currently a draft PR as due to the uncertain state of staging branches