Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include both raw term keys and full term URIs in vocabulary content serialized into JSON -- 3 #367

Closed
paregorios opened this issue Mar 26, 2019 · 6 comments · May be fixed by isawnyu/PleiadesEntity#36
Closed

include both raw term keys and full term URIs in vocabulary content serialized into JSON -- 3 #367

paregorios opened this issue Mar 26, 2019 · 6 comments · May be fixed by isawnyu/PleiadesEntity#36
Assignees
@MatthewWilkes
Labels
enhancement priority: high
Milestone
spring 2019

Comments

@paregorios
Copy link
Member

The following has been split out separately from #271:

As a user of Pleiades export JSON, I will find the following terms in JSON data (both the individual files provided for each place using the /json stub and those provided via download):

association certainty

Where we emit "associationCertainty" also emit "associationCertaintyURI":

...
"associationCertainty": "certain",
"associationCertaintyURI": "https://pleiades.stoa.org/vocabularies/association-certainty/certain",
...

attestation confidence and time periods

Under "attestations" when we emit "confidence" also emit "confidenceURI" and when we emit "timePeriod" also emit "timePeriodURI":

...
"confidence": "confident",
"confidenceURI": "https://pleiades.stoa.org/vocabularies/attestation-confidence/confident",
"timePeriod": "roman",
"timePeriodURI": "https://pleiades.stoa.org/vocabularies/time-periods/roman",
...

feature types

Wherever we emit "featureType" also emit "featureTypeURI":

...
"featureType": [
    "plaza"
],
"featureTypeURI": [
    "https://pleiades.stoa.org/vocabularies/place-types/plaza"
],
...

place types

Wherever we emit "placeTypes" also emit "placeTypeURIs":

...
"placeTypes": [
    "plaza"
],
"placeTypeURIs": [
    "https://pleiades.stoa.org/vocabularies/place-types/plaza"
],
...

location type

Wherever we emit "locationType" also emit "locationTypeURI":

...
"locationType": [
    "representative"
],
"locationTypeURI": [
    "https://pleiades.stoa.org/vocabularies/location-types/representative"
],
...

reference citation type

Wherever we emit "type" under "references"*, also emit "citationTypeURI":

...
"type": "citesAsDataSource",
"citationTypeURI": "http://purl.org/spar/cito/citesAsDataSource",
...
@paregorios paregorios added this to the spring 2019 milestone Mar 26, 2019
@paregorios paregorios mentioned this issue Mar 26, 2019
Open
@skleinfeldt skleinfeldt changed the title include both raw term keys and full term URIs in vocabulary content serialized into JSON include both raw term keys and full term URIs in vocabulary content serialized into JSON -- 3 Mar 26, 2019
@MatthewWilkes MatthewWilkes self-assigned this Mar 29, 2019
@MatthewWilkes MatthewWilkes mentioned this issue Mar 29, 2019
Open
@paregorios
Copy link
Member Author

It looks like @cguardia has finished review of the pull request, so I think the next step (right @skleinfeldt ?) is to put this change on staging so that I can look at the json output from a live system.

@skleinfeldt
Copy link

See #345 (comment)

@MatthewWilkes
Copy link
Member

@paregorios This has been deployed to staging

@paregorios
Copy link
Member Author

This looks good. Please merge to master and deploy to production.

@MatthewWilkes
Copy link
Member

Deployed this to live

@paregorios paregorios mentioned this issue Apr 15, 2019
Closed
@paregorios
Copy link
Member Author

Looks good on production. Closing as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MatthewWilkes MatthewWilkes

Labels
enhancement priority: high
Projects
None yet
Milestone
spring 2019
Development

Successfully merging a pull request may close this issue.

Add URI to various vocabulary JSON fields isawnyu/PleiadesEntity
3 participants
@MatthewWilkes @paregorios @skleinfeldt