Add transition slop zones and update tests #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the quadrants now have slop they are mutually exclusive from the axes. But some lines travel through an axis which should *need to* consider the axis. This is particularly the case for graphs such as x^2 which would leave a quadrant and enter and axis before entering the origin. This is counter-intuitive. These transition zones allow for the matching algorithm to catch these cases. By only adding in these zones in specific cases (that is where a line would need to transition from/into a zone from a quadrant) we can control whether to add or ignore axis leeway.
jacbn
approved these changes
Nov 13, 2023
library/src/main/java/org/isaacphysics/graphchecker/geometry/SectorBuilder.java
Outdated
Show resolved
Hide resolved
library/src/main/java/org/isaacphysics/graphchecker/geometry/SectorBuilder.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jacob Brown <[email protected]>
Co-authored-by: Jacob Brown <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the quadrants now have slop they are mutually exclusive from the axes. But some lines travel through an axis which should need to consider the axis.
This is particularly the case for graphs such as x^2 which would leave a quadrant and enter and axis before entering the origin. This is counter-intuitive.
These transition zones allow for the matching algorithm to catch these cases. By only adding in these zones in specific cases (that is where a line would need to transition from/into a zone from a quadrant) we can control whether to add or ignore axis leeway.