Coordinate validator changes #664
Conversation
Move the generally useful too few/many sig fig functions from the numeric validator to utils, and use them to check for correctness of significant figures in coordinate questions.
| @@ -192,6 +199,9 @@ List<CoordinateItem> orderCoordinates(final List<CoordinateItem> items) { | |||
| for (int i = 0; i < numDimensions; i++) { | |||
| String valueA = a.getCoordinates().get(i); | |||
| String valueB = b.getCoordinates().get(i); | |||
| if (valueA.isEmpty() || valueB.isEmpty()) { | |||
| return 0; | |||
There was a problem hiding this comment.
I don't think zero is right here, because zero would mean they are equal.
I think if one is empty, we should return something more like valueA.compareTo(valueB)? That will at least put the empty ones somewhere stable (which is necessary to avoid runtime exceptions).
There was a problem hiding this comment.
Agreed - sorting the empty strings to the start of the list affects the feedback that is given in some cases (since we'll always check empty values before anything else), but that's probably an improvement.
|
|
||
| boolean valuesMatch = ValidationUtils.numericValuesMatch(choiceValue, submittedValue, sigFigs, log); | ||
| if (submittedValue.isEmpty()) { | ||
| feedback = new Content("You did not provide a complete answer."); |
There was a problem hiding this comment.
Could this feedback be a constant, like we have done already for some common ones? I can see it being used elsewhere, unlike the other ones.
There was a problem hiding this comment.
Done (only used here for now - there are some cloze/reorder cases where it might work, but their feedback is currently more specific).
Small changes to the coordinate question validator: