Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give charge feedback in the Chemistry Checker #655

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

sjd210
Copy link
Contributor

@sjd210 sjd210 commented Nov 12, 2024

This includes two new piece of feedback:

  • "Your equation's charge is unbalanced!" - when an equation has less charge on one side than the other.
  • "Check your charges" - when an equation otherwise has an incorrect answer due to charge

(Reliant on this change to the Chemistry Checker)

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 34.38%. Comparing base (980cd78) to head (59bb514).
Report is 42 commits behind head on master.

Files with missing lines Patch % Lines
...tg/isaac/quiz/IsaacSymbolicChemistryValidator.java 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #655      +/-   ##
==========================================
+ Coverage   34.15%   34.38%   +0.23%     
==========================================
  Files         519      521       +2     
  Lines       23263    23385     +122     
  Branches     2854     2866      +12     
==========================================
+ Hits         7946     8042      +96     
- Misses      14515    14535      +20     
- Partials      802      808       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjd210 sjd210 merged commit eb9ca65 into master Nov 26, 2024
3 checks passed
@sjd210 sjd210 deleted the improvement/chemistry-charge-feedback branch November 26, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants