Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix electron representations #11

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Fix electron representations #11

merged 4 commits into from
Dec 19, 2024

Conversation

sjd210
Copy link
Contributor

@sjd210 sjd210 commented Dec 11, 2024

There are two similar but unrelated issues with electron/subatomic particle representation in the chemistry/nuclear checker respectively currently, each breaking certain ways that an answer can be accepted.

  • Chemistry: Electrons have inherent +1 charge that is not represented as a property. This charge wasn't being counted in chargeCount, and so non-exact matching for half-equations was failing.

  • Nuclear: Subatomic particles without mass (e.g. electrons, neutrinos, betaparticles) are sometimes allowed in Content as answers without mass/atomic numbers attached (as well as the same answer WITH the numbers attached). We had been assuming that missing mass/atomic numbers were erroneous, but this has now been disabled for massless particles and instead the values default to correct.

@sjd210 sjd210 marked this pull request as ready for review December 11, 2024 11:11
@sjd210
Copy link
Contributor Author

sjd210 commented Dec 11, 2024

Note to say that the tests are failing on this branch because the PR with them fixed has yet to be looked over.

This branch passes all those tests, and I have a couple more ready to add to it once either branch is merged.

@jsharkey13 jsharkey13 merged commit 4529f69 into main Dec 19, 2024
1 check passed
@jsharkey13 jsharkey13 deleted the hotfix/electron-charge branch December 19, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants