Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate CreateInMemory parameters #275

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Validate CreateInMemory parameters #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions OpenMcdf/RootStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ private static void ThrowIfInvalid(FileAccess access)
private static void ThrowIfLeaveOpen(StorageModeFlags flags)
{
if (flags.HasFlag(StorageModeFlags.LeaveOpen))
throw new ArgumentException($"{StorageModeFlags.LeaveOpen} is not valid for files");
throw new ArgumentException($"{StorageModeFlags.LeaveOpen} is only valid for injected streams.");
}

private static IOContextFlags ToIOContextFlags(StorageModeFlags flags)
Expand Down Expand Up @@ -78,7 +78,12 @@ public static RootStorage Create(Stream stream, Version version = Version.V3, St
return new RootStorage(rootContextSite, flags);
}

public static RootStorage CreateInMemory(Version version = Version.V3, StorageModeFlags flags = StorageModeFlags.None) => Create(new MemoryStream(), version, flags);
public static RootStorage CreateInMemory(Version version = Version.V3, StorageModeFlags flags = StorageModeFlags.None)
{
ThrowIfLeaveOpen(flags);

return Create(new MemoryStream(), version, flags);
}

public static RootStorage Open(string fileName, FileMode mode, StorageModeFlags flags = StorageModeFlags.None)
{
Expand Down
Loading