Feature/power on machine for inventory #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gchbg
previously approved these changes
Jun 13, 2024
aobort
force-pushed
the
feature/power-on-machine-for-inventory
branch
from
75bc841 to
380f6e9
Compare
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
aobort
force-pushed
the
feature/power-on-machine-for-inventory
branch
from
380f6e9 to
cdf55e4
Compare
Gchbg
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
added:
machine.spec.inventoryRefif it is nil andmachine.spec.powerto "PowerOff" after thatmachine.spec.powerto "PowerOn" in casemachine.spec.inventoryRefis nil andmachine.status.stateis "Initial" or emptyIt is needed to boot newly created machine and collect inventory data.
Which issue(s) this PR fixes:
Fixes #103
Special notes for your reviewer:
Tests are not adopted to changes in this PR. Three oob tests will fail because it is expected that machine does not change it's
spec.powerfield. Addingspec.inventoryRefand settingspec.powerto "PowerOff` prior to test case main checks fixes the issue.Release note:
NONE