Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dummy defaulter for each Webhook #340

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Add dummy defaulter for each Webhook #340

merged 1 commit into from
Jun 10, 2024

Conversation

damyan
Copy link
Member

@damyan damyan commented Jun 10, 2024

Otherwise the controller complains:
INFO controller-runtime.builder skip registering a mutating webhook, object does not implement admission.Defaulter or WithDefaulter wasn't called {"GVK": "ipam.metal.ironcore.dev/v1alpha1, Kind=IP"}

Otherwise the controller complains:
`INFO    controller-runtime.builder    skip registering a mutating
webhook, object does not implement admission.Defaulter or WithDefaulter
wasn't called    {"GVK": "ipam.metal.ironcore.dev/v1alpha1, Kind=IP"}`
@damyan damyan added the bug Something isn't working label Jun 10, 2024
@damyan damyan requested a review from aobort June 10, 2024 12:04
Copy link
Contributor

@aobort aobort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damyan damyan merged commit b8c17af into main Jun 10, 2024
9 checks passed
@damyan damyan deleted the fix/fix-webhooks branch June 10, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants