Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include ServerClaim UID in Node ProviderID #29

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Include ServerClaim UID in Node ProviderID #29

merged 1 commit into from
Oct 10, 2024

Conversation

afritzler
Copy link
Member

Proposed Changes

Include ServerClaim UID in Node ProviderID.

providerID: metal://<namespace>/<serverclaim-name>/<serverclaim-uid>

Fixes #17

@afritzler afritzler requested a review from a team as a code owner October 10, 2024 11:36
@github-actions github-actions bot added size/M enhancement New feature or request labels Oct 10, 2024
@afritzler afritzler requested review from defo89 and Nuckal777 October 10, 2024 11:36
@afritzler afritzler force-pushed the enh/provider-id branch 2 times, most recently from 84c8254 to 2fc483c Compare October 10, 2024 11:43
Nuckal777
Nuckal777 approved these changes Oct 10, 2024
View reviewed changes
pkg/cloudprovider/metal/instances_v2_test.go Outdated Show resolved Hide resolved
@afritzler afritzler merged commit d6e03dc into main Oct 10, 2024
8 checks passed
@afritzler afritzler deleted the enh/provider-id branch October 10, 2024 11:53
defo89 added a commit that referenced this pull request Oct 30, 2024
@defo89
Revert "Include ServerClaim UID in Node ProviderID (#29)"
62079d8 
This reverts commit d6e03dc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuckal777 Nuckal777 Nuckal777 approved these changes

@defo89 defo89 Awaiting requested review from defo89

Assignees
No one assigned
Labels
enhancement New feature or request size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set Correct ProviderID Format in cloud-provider-metal
2 participants
@afritzler @Nuckal777