Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor flag parsing and logging #187

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Refactor flag parsing and logging #187

merged 3 commits into from
Sep 25, 2024

Conversation

afritzler
Copy link
Member

@afritzler afritzler commented Sep 24, 2024

Proposed Changes

Use idiomatic golang flag parsing. Use propper logging setup instead of custom logger with custom flags.

Usage of ./bin/fedhcp:
  -config string
        config file
  -kubeconfig string
        Paths to a kubeconfig. Only required if out-of-cluster.
  -list-plugins
        list plugins

This is a breaking change as the flag names have changed.

@afritzler afritzler force-pushed the enh/refactor-main branch 2 times, most recently from 456bc63 to d116a1c Compare September 24, 2024 12:35
@afritzler afritzler added the enhancement New feature or request label Sep 24, 2024
@afritzler afritzler requested a review from damyan September 24, 2024 12:35
Use idiomatic golang flag parsing. Use propper logging setup instead of
custom logger with custom flags.
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Show resolved Hide resolved
@damyan damyan merged commit 39628e6 into main Sep 25, 2024
8 checks passed
@damyan damyan deleted the enh/refactor-main branch September 25, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants