Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update module mod #457

Merged
merged 3 commits into from
Nov 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions modules/nft/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ require (
google.golang.org/genproto/googleapis/api v0.0.0-20240318140521-94a12d6c2237
google.golang.org/grpc v1.64.1
google.golang.org/protobuf v1.34.2
mods.irisnet.org/api v0.0.0-20240628054110-4cb043e0238a
mods.irisnet.org/simapp v0.0.0-20240628054110-4cb043e0238a
mods.irisnet.org/api v0.0.0-20241118093307-345265846e1d
mods.irisnet.org/simapp v0.0.0-20241118093307-345265846e1d
)

require (
Expand Down Expand Up @@ -213,7 +213,4 @@ replace (
// Downgraded to avoid bugs in following commits which caused simulations to fail.
github.com/syndtr/goleveldb => github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7

// todo replace version
mods.irisnet.org/simapp => ../../simapp

)
6 changes: 4 additions & 2 deletions modules/nft/go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -1727,8 +1727,10 @@ honnef.co/go/tools v0.0.0-20190523083050-ea95bdfd59fc/go.mod h1:rf3lG4BRIbNafJWh
honnef.co/go/tools v0.0.1-2019.2.3/go.mod h1:a3bituU0lyd329TUQxRnasdCoJDkEUEAqEt0JzvZhAg=
honnef.co/go/tools v0.0.1-2020.1.3/go.mod h1:X/FiERA/W4tHapMX5mGpAtMSVEeEUOyHaw9vFzvIQ3k=
honnef.co/go/tools v0.0.1-2020.1.4/go.mod h1:X/FiERA/W4tHapMX5mGpAtMSVEeEUOyHaw9vFzvIQ3k=
mods.irisnet.org/api v0.0.0-20240628054110-4cb043e0238a h1:/MLyi/CV2TrCVtGREoSpeLpXZvCgIUfbe3vqy8Lo/k4=
mods.irisnet.org/api v0.0.0-20240628054110-4cb043e0238a/go.mod h1:TpMaRRYSpqsXdeX4gDVFRj9ggedQ60Zcjs4iE2DIhsc=
mods.irisnet.org/api v0.0.0-20241118093307-345265846e1d h1:O9WkEH5ydPGg32YL+fVQr5MFOuYqjZFdIekTpiWU7bg=
mods.irisnet.org/api v0.0.0-20241118093307-345265846e1d/go.mod h1:TpMaRRYSpqsXdeX4gDVFRj9ggedQ60Zcjs4iE2DIhsc=
mods.irisnet.org/simapp v0.0.0-20241118093307-345265846e1d h1:rZjX7uXO6xGZgZIj3xnMkiGik1VXZRFqceR11rZb5pw=
mods.irisnet.org/simapp v0.0.0-20241118093307-345265846e1d/go.mod h1:t7FSQJkJOgXq1/LdhpBeOu7TS8hLQkAMMx9fL5w53PY=
nhooyr.io/websocket v1.8.6 h1:s+C3xAMLwGmlI31Nyn/eAehUlZPwfYZu2JXM621Q5/k=
nhooyr.io/websocket v1.8.6/go.mod h1:B70DZP8IakI65RVQ51MsWP/8jndNma26DVA/nFSCgW0=
pgregory.net/rapid v1.1.0 h1:CMa0sjHSru3puNx+J0MIAuiiEV4N0qj8/cMWGBBCsjw=
Expand Down
6 changes: 2 additions & 4 deletions modules/random/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ require (
google.golang.org/grpc v1.64.1
google.golang.org/protobuf v1.34.2
mods.irisnet.org/api v0.0.0-20240628054110-4cb043e0238a
mods.irisnet.org/modules/service v0.0.0-20240628073359-e86a7a18ad5d
mods.irisnet.org/simapp v0.0.0-20240628054110-4cb043e0238a
mods.irisnet.org/modules/service v0.0.0-20241118093307-345265846e1d
mods.irisnet.org/simapp v0.0.0-20241118093307-345265846e1d
)

require (
Expand Down Expand Up @@ -214,6 +214,4 @@ replace (
// Downgraded to avoid bugs in following commits which caused simulations to fail.
github.com/syndtr/goleveldb => github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7

mods.irisnet.org/modules/service => ../service
mods.irisnet.org/simapp => ../../simapp
)
4 changes: 4 additions & 0 deletions modules/random/go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -1727,6 +1727,10 @@ honnef.co/go/tools v0.0.1-2020.1.3/go.mod h1:X/FiERA/W4tHapMX5mGpAtMSVEeEUOyHaw9
honnef.co/go/tools v0.0.1-2020.1.4/go.mod h1:X/FiERA/W4tHapMX5mGpAtMSVEeEUOyHaw9vFzvIQ3k=
mods.irisnet.org/api v0.0.0-20240628054110-4cb043e0238a h1:/MLyi/CV2TrCVtGREoSpeLpXZvCgIUfbe3vqy8Lo/k4=
mods.irisnet.org/api v0.0.0-20240628054110-4cb043e0238a/go.mod h1:TpMaRRYSpqsXdeX4gDVFRj9ggedQ60Zcjs4iE2DIhsc=
mods.irisnet.org/modules/service v0.0.0-20241118093307-345265846e1d h1:T16pj3UU2X0aqlZ/oCABH8Vzh0ikDCU4HTn/dNcCcfw=
mods.irisnet.org/modules/service v0.0.0-20241118093307-345265846e1d/go.mod h1:ZGxV+r9sUlgCL8mrH0GT/Nqen37vw0yK80NojqNZTYM=
mods.irisnet.org/simapp v0.0.0-20241118093307-345265846e1d h1:rZjX7uXO6xGZgZIj3xnMkiGik1VXZRFqceR11rZb5pw=
mods.irisnet.org/simapp v0.0.0-20241118093307-345265846e1d/go.mod h1:t7FSQJkJOgXq1/LdhpBeOu7TS8hLQkAMMx9fL5w53PY=
nhooyr.io/websocket v1.8.6 h1:s+C3xAMLwGmlI31Nyn/eAehUlZPwfYZu2JXM621Q5/k=
nhooyr.io/websocket v1.8.6/go.mod h1:B70DZP8IakI65RVQ51MsWP/8jndNma26DVA/nFSCgW0=
pgregory.net/rapid v1.1.0 h1:CMa0sjHSru3puNx+J0MIAuiiEV4N0qj8/cMWGBBCsjw=
Expand Down
8 changes: 2 additions & 6 deletions modules/record/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ require (
google.golang.org/genproto/googleapis/api v0.0.0-20240318140521-94a12d6c2237
google.golang.org/grpc v1.64.1
google.golang.org/protobuf v1.34.2
mods.irisnet.org/api v0.0.0-20240628054110-4cb043e0238a
mods.irisnet.org/simapp v0.0.0-20240628054110-4cb043e0238a
mods.irisnet.org/api v0.0.0-20241118093307-345265846e1d
mods.irisnet.org/simapp v0.0.0-20241118093307-345265846e1d
)

require (
Expand Down Expand Up @@ -205,8 +205,4 @@ replace (
github.com/gin-gonic/gin => github.com/gin-gonic/gin v1.9.0
// Downgraded to avoid bugs in following commits which caused simulations to fail.
github.com/syndtr/goleveldb => github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7

//todo replace version
mods.irisnet.org/api => ../../api
mods.irisnet.org/simapp => ../../simapp
)
4 changes: 4 additions & 0 deletions modules/record/go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -1713,6 +1713,10 @@ honnef.co/go/tools v0.0.0-20190523083050-ea95bdfd59fc/go.mod h1:rf3lG4BRIbNafJWh
honnef.co/go/tools v0.0.1-2019.2.3/go.mod h1:a3bituU0lyd329TUQxRnasdCoJDkEUEAqEt0JzvZhAg=
honnef.co/go/tools v0.0.1-2020.1.3/go.mod h1:X/FiERA/W4tHapMX5mGpAtMSVEeEUOyHaw9vFzvIQ3k=
honnef.co/go/tools v0.0.1-2020.1.4/go.mod h1:X/FiERA/W4tHapMX5mGpAtMSVEeEUOyHaw9vFzvIQ3k=
mods.irisnet.org/api v0.0.0-20241118093307-345265846e1d h1:O9WkEH5ydPGg32YL+fVQr5MFOuYqjZFdIekTpiWU7bg=
mods.irisnet.org/api v0.0.0-20241118093307-345265846e1d/go.mod h1:TpMaRRYSpqsXdeX4gDVFRj9ggedQ60Zcjs4iE2DIhsc=
mods.irisnet.org/simapp v0.0.0-20241118093307-345265846e1d h1:rZjX7uXO6xGZgZIj3xnMkiGik1VXZRFqceR11rZb5pw=
mods.irisnet.org/simapp v0.0.0-20241118093307-345265846e1d/go.mod h1:t7FSQJkJOgXq1/LdhpBeOu7TS8hLQkAMMx9fL5w53PY=
nhooyr.io/websocket v1.8.6 h1:s+C3xAMLwGmlI31Nyn/eAehUlZPwfYZu2JXM621Q5/k=
nhooyr.io/websocket v1.8.6/go.mod h1:B70DZP8IakI65RVQ51MsWP/8jndNma26DVA/nFSCgW0=
pgregory.net/rapid v1.1.0 h1:CMa0sjHSru3puNx+J0MIAuiiEV4N0qj8/cMWGBBCsjw=
Expand Down
8 changes: 2 additions & 6 deletions modules/service/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ require (
google.golang.org/grpc v1.64.1
google.golang.org/protobuf v1.34.2
gopkg.in/yaml.v2 v2.4.0
mods.irisnet.org/api v0.0.0-20240628054110-4cb043e0238a
mods.irisnet.org/simapp v0.0.0-20240628054110-4cb043e0238a
mods.irisnet.org/api v0.0.0-20241118093307-345265846e1d
mods.irisnet.org/simapp v0.0.0-20241118093307-345265846e1d
Comment on lines +31 to +32
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Version inconsistency detected in random module

The random module is using an older version of mods.irisnet.org/api (v0.0.0-20240628054110-4cb043e0238a) while all other modules are using the newer version (v0.0.0-20241118093307-345265846e1d). This inconsistency should be addressed:

  • modules/random/go.mod: Update mods.irisnet.org/api to v0.0.0-20241118093307-345265846e1d to match other modules
🔗 Analysis chain

Verify version consistency across dependent modules

Both dependencies are updated to use the same commit hash (345265846e1d), which is good for consistency. However, let's verify this update across all related modules.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check version consistency across modules
# Expected: All modules should use the same version for these dependencies

echo "Checking version consistency across modules..."
for module in nft random record service; do
  echo "\nChecking modules/$module/go.mod:"
  rg "mods\.irisnet\.org/(api|simapp)" "modules/$module/go.mod"
done

Length of output: 1284

)

require (
Expand Down Expand Up @@ -212,8 +212,4 @@ replace (
github.com/gin-gonic/gin => github.com/gin-gonic/gin v1.9.0
// Downgraded to avoid bugs in following commits which caused simulations to fail.
github.com/syndtr/goleveldb => github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7

// todo replace version
mods.irisnet.org/api => ../../api
mods.irisnet.org/simapp => ../../simapp
)
4 changes: 4 additions & 0 deletions modules/service/go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -1725,6 +1725,10 @@ honnef.co/go/tools v0.0.0-20190523083050-ea95bdfd59fc/go.mod h1:rf3lG4BRIbNafJWh
honnef.co/go/tools v0.0.1-2019.2.3/go.mod h1:a3bituU0lyd329TUQxRnasdCoJDkEUEAqEt0JzvZhAg=
honnef.co/go/tools v0.0.1-2020.1.3/go.mod h1:X/FiERA/W4tHapMX5mGpAtMSVEeEUOyHaw9vFzvIQ3k=
honnef.co/go/tools v0.0.1-2020.1.4/go.mod h1:X/FiERA/W4tHapMX5mGpAtMSVEeEUOyHaw9vFzvIQ3k=
mods.irisnet.org/api v0.0.0-20241118093307-345265846e1d h1:O9WkEH5ydPGg32YL+fVQr5MFOuYqjZFdIekTpiWU7bg=
mods.irisnet.org/api v0.0.0-20241118093307-345265846e1d/go.mod h1:TpMaRRYSpqsXdeX4gDVFRj9ggedQ60Zcjs4iE2DIhsc=
mods.irisnet.org/simapp v0.0.0-20241118093307-345265846e1d h1:rZjX7uXO6xGZgZIj3xnMkiGik1VXZRFqceR11rZb5pw=
mods.irisnet.org/simapp v0.0.0-20241118093307-345265846e1d/go.mod h1:t7FSQJkJOgXq1/LdhpBeOu7TS8hLQkAMMx9fL5w53PY=
nhooyr.io/websocket v1.8.6 h1:s+C3xAMLwGmlI31Nyn/eAehUlZPwfYZu2JXM621Q5/k=
nhooyr.io/websocket v1.8.6/go.mod h1:B70DZP8IakI65RVQ51MsWP/8jndNma26DVA/nFSCgW0=
pgregory.net/rapid v1.1.0 h1:CMa0sjHSru3puNx+J0MIAuiiEV4N0qj8/cMWGBBCsjw=
Expand Down
Loading