Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve handling of optional dependencies #213

Merged
merged 3 commits into from
Nov 17, 2023
Merged

feat: improve handling of optional dependencies #213

merged 3 commits into from
Nov 17, 2023

Conversation

alexander-held
Copy link
Member

Refactor imports to allow running without ServiceX client (and related libraries) installed. Also avoid importing everything into utils to ensure cabinetry is not needed on worker nodes (which import utils at the top level).

oshadura
oshadura approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@oshadura oshadura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works for locally! I would like to merge to check on the new setup we have at UNL.

@oshadura oshadura merged commit 65db0d6 into main Nov 17, 2023
2 checks passed
@alexander-held alexander-held deleted the feat/optional-dependencies branch November 17, 2023 14:10
@alexander-held alexander-held mentioned this pull request Nov 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshadura oshadura oshadura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexander-held @oshadura