Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

***WIP*** RDPHOEN-463 "Driver for dynamic resolution shifting" #1

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from
Draft

***WIP*** RDPHOEN-463 "Driver for dynamic resolution shifting" #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b949d4d
[RDPHOEN-463/RDPHOEN-467] Clean Up Driver Code
Oct 13, 2021
4327d0e
RDPHOEN-463/RDPHOEN-467] Added comments
Oct 13, 2021
479b9eb
[RDPHOEN-463/RDPHOEN-467] Removed unused code
Oct 13, 2021
31b7b8c
[RDPHOEN-463] Added #define DEBUG and printouts
Oct 13, 2021
e63d780
[RDPHOEN-463/RDPHOEN-507] Removed "epc660_try_format"
Oct 13, 2021
1c1f5fc
[RDPHOEN-463/RDPHOEN-464] Remove line sorting in "buffer_init"
Oct 13, 2021
888c5e9
[RDPHOEN-463/RDPHOEN-593] ioctl function "epc600_s_parm"
Oct 13, 2021
3b562c1
[RDPHOEN-463/RDPHOEN-522] Bugfix the EPC660 driver
Oct 15, 2021
e9bf8dc
[RDPHOEN-644] Enable the DCS configuration
Oct 15, 2021
e16a60e
[PDPHOEN-463/RDPHOEN-689] Set 1_DCS channels to "1"
Oct 21, 2021
ef79f18
[PDPHOEN-463/RDPHOEN-689] Some formatting changes
Oct 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions drivers/media/i2c/soc_camera/epc660.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,10 @@ struct epc660_datafmt {
enum v4l2_colorspace colorspace;
};

/* Find a data format by a pixel code in an array */
/**
* @brief Find a data format by a pixel code in an array
* @brief Used in epc660_set_fmt
*/
static const struct epc660_datafmt *epc660_find_datafmt(
u32 code, const struct epc660_datafmt *fmt,
int n)
Expand All @@ -58,13 +61,15 @@ static const struct epc660_datafmt *epc660_find_datafmt(
return NULL;
}

/**
* @brief used to store sensor supported formats
* @brief corresponding with "static const struct imager_format epc660_formats[]" in epc660_capture_sc57x.c @JAHA ToDo: Change this?
*/
static const struct epc660_datafmt epc660_monochrome_fmts[] = {
/* Order important - see above */
{MEDIA_BUS_FMT_Y12_1X12, V4L2_COLORSPACE_JPEG},
{MEDIA_BUS_FMT_EPC660_2X12, V4L2_COLORSPACE_JPEG},
{MEDIA_BUS_FMT_EPC660_3X12, V4L2_COLORSPACE_JPEG},
{MEDIA_BUS_FMT_EPC660_4X12, V4L2_COLORSPACE_JPEG},
{MEDIA_BUS_FMT_EPC660_5X12, V4L2_COLORSPACE_JPEG},
};

struct epc660 {
Expand Down Expand Up @@ -166,9 +171,8 @@ static int epc660_eeprom_read_word(struct i2c_client *client,
}

/*
* Send an I2C sequence to the imager.
*
* Return 0 on success, otherwise the i2c return code.
* @brief Send an I2C sequence to the imager. Used in function epc660_load_fw
* @brief Return 0 on success, otherwise the i2c return code.
*/
static int epc660_send_i2c_sequence(struct i2c_client *client,
const u8 *seq)
Expand Down Expand Up @@ -405,6 +409,9 @@ static long epc660_ioctl(struct v4l2_subdev *sd, unsigned int cmd, void* arg)
return 0;
}

/**
* @brief Function for (re-)setting the reset pin of the EPC660
*/
static int epc660_reset(struct v4l2_subdev *sd, u32 val) {
struct i2c_client *client = v4l2_get_subdevdata(sd);
struct epc660 *epc660 = to_epc660(client);
Expand Down Expand Up @@ -457,8 +464,8 @@ static int epc660_load_fw(struct v4l2_subdev *sd) {


/*
* Interface active, can use i2c. If it fails, it can indeed mean, that
* this wasn't our capture interface, so, we wait for the right one
* @brief Interface active, can use i2c. If it fails, it can indeed mean, that
* @brief this wasn't our capture interface, so, we wait for the right one. Used by epc660_probe.
*/
static int epc660_video_probe(struct i2c_client *client)
{
Expand Down
Loading