[iree.build] Make the fetch_http action more robust. #19330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Downloads to a staging file and then atomically renames into place, avoiding potential for partial downloads. * Reports completion percent as part of the console updates. * Persists metadata for the source URL and will refetch if changed. * Fixes an error handling test for the onnx mnist_builder that missed the prior update. More sophistication is possible but this brings it up to min-viable from a usability perspective. Signed-off-by: Stella Laurenzo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More sophistication is possible but this brings it up to min-viable from a usability perspective.