[GPU] Add pattern to fuse tensor.collapse_shape into forall producer #19295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR is mostly ready, but I need to add more lit tests and improve the docs. EDIT: Ready now |
Max191
force-pushed
the
collapse-shape-forall-fusion
branch
from
4eb7167
to
04c4f2b
Compare
Max191
force-pushed
the
collapse-shape-forall-fusion
branch
from
04c4f2b
to
5639b90
Compare
added 2 commits
November 26, 2024 14:22
Signed-off-by: Max Dawkins <[email protected]>
Signed-off-by: Max Dawkins <[email protected]>
Max191
force-pushed
the
collapse-shape-forall-fusion
branch
from
5639b90
to
688e8cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a pattern to fuse a consumer tensor.collapse_shape into a producer scf.forall op. The transform is added to FuseAndHoistParallelLoops, where it helps to fuse tensor.unpack ops with extract_slice semantics into producer loops. This is needed when targeting MFMA intrinsics for unaligned shapes, and also in generating code for unset encoding ops on GPU.
The PR also adds a transform op to keep the long lit tests separate from the FuseAndHoistParallelLoop tests.