[TKW] Optimize trivial gather offsets #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@harsh-nod here is the patch to get rid of trivial gathers |
Thanks |
Hardcode84
force-pushed
the
gather-cont
branch
from
704c227
to
d2e506a
Compare
Hardcode84
changed the title
Signed-off-by: Ivan Butygin <[email protected]>
Signed-off-by: Ivan Butygin <[email protected]>
Hardcode84
force-pushed
the
gather-cont
branch
from
d2e506a
to
71c0564
Compare
raikonenfnu
reviewed
Nov 26, 2024
Yeah, it's kind of hard to construct artificial example for it. |
raikonenfnu
reviewed
Nov 26, 2024
raikonenfnu
approved these changes
Nov 26, 2024
Hardcode84
added a commit
to Hardcode84/iree-turbine
that referenced
this pull request
Nov 26, 2024
Update gather/scatter offset generation to handle trivial contiguous offsets (i.e. `[0,1,2,3]`) and generate contiguous load/store instead. --------- Signed-off-by: Ivan Butygin <[email protected]>
Hardcode84
added a commit
that referenced
this pull request
Nov 26, 2024
Signed-off-by: Ivan Butygin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update gather/scatter offset generation to handle trivial contiguous offsets (i.e.
[0,1,2,3]) and generate contiguous load/store instead.