Fix error of test's compilation #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ireader
reviewed
Jul 21, 2019
| @@ -25,6 +27,10 @@ int async_pipe_read(async_pipe_t pipe, void* msg, int len, async_pipe_onread cal | |||
| // return: 0-success, other-error | |||
| int async_pipe_write(async_pipe_t pipe, const void* msg, int len, async_pipe_onwrite callback, void* param); | |||
|
|
|||
| static void aio_onread(sigval_t sigval); | |||
|
|
|||
| static void aio_onwrite(sigval_t sigval); | |||
There was a problem hiding this comment.
Declare static aio_onread/aio_onwrite ?
There was a problem hiding this comment.
Yes, compiler didn't found this functions in linux-async-pipe.c without declaration in this include file. Maybe this functions can be declared in linux-async-pipe.c?
| @@ -46,7 +46,7 @@ else | |||
| LIBPATHS += | |||
| endif | |||
|
|
|||
| LIBS = rt pthread dl aio | |||
| LIBS = rt pthread dl aio asan | |||
There was a problem hiding this comment.
maybe i should delete -fsanitize=address option in gcc.mk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make returned errors of undeclared "aio_write", "aio_read" and "sigval_t" in 'linux-async-pipe.c'. And make RELEASE=1 didn't work without -lasan flag.