Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pytest commands in README #1178

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Update pytest commands in README #1178

merged 1 commit into from
Dec 4, 2023

Conversation

ianthomas23
Copy link
Collaborator

This PR updates the two pytest commands in the README to be the same as those in CI and the various hatch commands. It replaces pytest ipykernel with pytest. An alternative would be to use the more explicit pytest tests, but this seems unnecessary.

Problem discovered when following the developer instructions for the first time.

This is my first contribution to ipykernel 😃

davidbrochart
davidbrochart approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ianthomas23, and welcome to ipykernel!

@davidbrochart davidbrochart merged commit 6154ba3 into ipython:main Dec 4, 2023
31 of 32 checks passed
@ianthomas23 ianthomas23 deleted the update_readme branch December 4, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbrochart davidbrochart davidbrochart approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianthomas23 @davidbrochart