House keeping #44
Merged
House keeping #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@UmanShahzad some tests failing here require IPINFO_TOKEN |
UmanShahzad
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm interested in contributing to this library. Before trying to tackle significant issues I was hoping to provide some house keeping.
All of these changes should be semver minor changes.
Typically it is hit or miss if a rustc edition bump is a breaking change. Here, the
Cargo.lockhas not been checked into the repo. If you want a consistent MSRV experience theCargo.lockis pretty much required. I also checked using cargo-msrv, a clean build of this repo require rustc version 1.63, which is well within 2021.