Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-enable code splitting #397

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat: re-enable code splitting #397

wants to merge 5 commits into from

Conversation

SgtPooki
Copy link
Member

  • feat: add code splitting back
  • chore: debugging
  • chore: debugging
  • chore: debugging
  • fix: firefox properly replaces old service worker

To debug this, follow this process:

npm run clean && npm run start
# load the page

# if you need to reload the old SW...
git checkout main
npm run clean && npm run start
# load the page

git checkout fix/splitting-sw
npm run clean && npm run start
# load the page

# repeat as needed

@SgtPooki SgtPooki marked this pull request as draft October 23, 2024 14:02
@SgtPooki
Copy link
Member Author

not sure why chrome is failing here.. we can address when code-splitting becomes a priority again

@2color
Copy link
Member

2color commented Oct 24, 2024

Do you have any rough numbers on the size of bundle before/after? This can probably help us evaluate the benefit we get out of code splitting.

@2color 2color marked this pull request as ready for review November 11, 2024 14:12
@SgtPooki SgtPooki marked this pull request as draft November 11, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants