Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default to bitswap-client-only #136

Merged
merged 2 commits into from
May 15, 2024
Merged

Conversation

lidel
Copy link
Member

@lidel lidel commented May 14, 2024

@aschmahmann as discussed, this restores bitswap setup we had in v1.0.0 where only the client is initialized by default.

If this looks ok, we can ship this as v1.2.2 and deploy to our infra.

This restores bitswap setup we had in v1.0.0 where only the client
is initialized by default.
@lidel lidel requested a review from aschmahmann May 14, 2024 17:04
bitswap.SetSendDontHaves(false),
)
bn.Start(bswap)
return &noNotifyExchange{bswap}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 I wonder if doing this (making NotifyNewBlocks no-op) has impact on the client. Just to be sure, we do not do this by default.

@lidel lidel force-pushed the fix/default-to-bitswap-client-only branch from dd0a978 to bd9e682 Compare May 14, 2024 17:09
@lidel lidel requested a review from hacdias May 14, 2024 17:15
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was was already a question I had when we introduced the peering, so it seems that it indeed creates more traffic. The change makes sense then.

Co-Authored-By: Marcin Rataj <[email protected]>
@hacdias hacdias force-pushed the fix/default-to-bitswap-client-only branch from ab00597 to 4273b79 Compare May 15, 2024 08:28
Copy link

Suggested version: v1.2.2

Comparing to: v1.2.1 (diff)

Changes in go.mod file(s):

(empty)

gorelease says:

# diagnostics
required module github.com/microcosm-cc/[email protected] retracted by module author: Retract older versions as only latest is to be depended upon

# summary
Suggested version: v1.2.2

gocompat says:

Your branch is up to date with 'origin/main'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to main. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

@hacdias hacdias enabled auto-merge (rebase) May 15, 2024 08:29
@hacdias hacdias merged commit d12f8b0 into main May 15, 2024
13 checks passed
@hacdias hacdias deleted the fix/default-to-bitswap-client-only branch May 15, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants