-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: default to bitswap-client-only #136
Conversation
This restores bitswap setup we had in v1.0.0 where only the client is initialized by default.
bitswap.SetSendDontHaves(false), | ||
) | ||
bn.Start(bswap) | ||
return &noNotifyExchange{bswap} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💭 I wonder if doing this (making NotifyNewBlocks
no-op) has impact on the client. Just to be sure, we do not do this by default.
dd0a978
to
bd9e682
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was was already a question I had when we introduced the peering, so it seems that it indeed creates more traffic. The change makes sense then.
Co-Authored-By: Marcin Rataj <[email protected]>
ab00597
to
4273b79
Compare
Suggested version: Changes in (empty)
Cutting a Release (and modifying non-markdown files)This PR is modifying both Automatically created GitHub ReleaseA draft GitHub Release has been created. |
@aschmahmann as discussed, this restores bitswap setup we had in v1.0.0 where only the client is initialized by default.
If this looks ok, we can ship this as v1.2.2 and deploy to our infra.