Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pinning compliance links #1943

Merged
merged 4 commits into from
Jun 15, 2022
Merged

Add pinning compliance links #1943

merged 4 commits into from
Jun 15, 2022

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Jun 8, 2022

This PR focuses on resolving the short term solution described in ipfs-shipyard/pinning-service-compliance#30

  • Add link to "set pinning" modal.
    2022-06-08 at 14 15 48 - Pin file modal compliance link

  • Add link to "add pinning provider" modal
    2022-06-08 at 14 15 48 - add pinning service modal compliance link

@welcome
Copy link

welcome bot commented Jun 8, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

Copy link

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I'll leave to others to review the code.

public/locales/en/files.json Outdated Show resolved Hide resolved
@SgtPooki SgtPooki requested a review from hacdias June 9, 2022 19:52
@SgtPooki
Copy link
Member Author

@hacdias one of the strings wasn't in transifex, but I've fixed that. will merge tomorrow if you or @lidel don't have anything blocking by then

@SgtPooki SgtPooki temporarily deployed to Deploy June 14, 2022 18:38 Inactive
@SgtPooki SgtPooki merged commit 7349a56 into main Jun 15, 2022
@SgtPooki SgtPooki deleted the pinning-compliance-link branch June 15, 2022 18:35
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SgtPooki fysa Transifex will fetch new source (English) strings within 24h after they land in main branch.
No need to manually add anything :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants