-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Crust pinner to remote pinning service #1854
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
Hey @hacdias Could you please take a look at this PR? |
@lidel Could you please take a look at this PR? |
@zikunfan apologies for slow reply. Pinning service support in webui landed in very basic form, and we are lacking proper test suite. |
@lidel Any progress? |
sadly no, I'm busy with ipfs/kubo#8183, will get to this when I have spare bandwidth. |
Yeah, I'll take a look and see how can I do for it |
dabaee3
to
7ddf870
Compare
@badkk the pinning service compliance checker is released now, can you add Crust there so we can check compliance prior to adding it? |
Oh, i'm sorry i just saw the PR mention since i was under business trip last 2 weeks! |
Hey @SgtPooki ! I've already solved this issue: ipfs-shipyard/pinning-service-compliance#154, would you please take a look! If you got any question need some instance help, my tg handler is: |
Thanks so much @badkk, I will be looking at that PR today |
PR for compliance checks: ipfs-shipyard/pinning-service-compliance#162 |
Hey @SgtPooki, do i need to do extra job on this PR? lmk if you got further questions? |
Hey @badkk, thanks for the ping. I'm concerned with adding crust to the list of default pinning providers when crust is currently failing all compliance checks. I also commented on ipfs-shipyard/pinning-service-compliance#154 (comment) |
Okay, we'll take a look at it, in the meanwhile did you add crust access token for the CI? Also does the CI different from https://github.com/ipfs-shipyard/pinning-service-compliance/actions/runs/3115068735 ? |
@badkk yes the token is added. You can see the latest scheduled run at https://github.com/ipfs-shipyard/pinning-service-compliance/actions/runs/3162850936 with logs and report in the artifacts listed beneath the run details |
Hey @SgtPooki we've updated Crust Pinning Service( |
The latest run was 4 days ago now and still showing a failure on all checks: https://ipfs-shipyard.github.io/pinning-service-compliance/pin.crustcode.com.html Is there anything we can update in the output to make debugging failures easier? If so, please open an issue at https://github.com/ipfs-shipyard/pinning-service-compliance so we can help get this across the finish line! |
A totally decentralized IPFS remote pinning service, now support:
And you can learn more about IPFS W3Auth Pinning Service here