-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: store: BatchOpStore (GetMany
/PutMany
methods)
#97
base: master
Are you sure you want to change the base?
Conversation
CBOR GetManyIpldStore
Rebase onto upstream v0.1.0
@i-norden are you still working on this set of changes? sorry nobody's been able to review your changes, if these are still in the path of your work we can prioritise them .. just not this week for me sorry but I'll keep it in my queue, it looks quite useful. |
Hey @rvagg sorry for abandoning this, we are no longer using this work but if there is still general interest in these changes and/or the linked PRs it is dependent on I can rebase and clean things up this week for review! |
Converted to draft for someone raises a production need for this. |
@gammazero fwiw this is used in production by @aschmahmann here: https://github.com/aschmahmann/filexp/blob/main/go.mod#L5-L7 Having either filecoin-project/go-hamt-ipld#103 or filecoin-project/go-hamt-ipld#115 merge would be really great. cc @rvagg |
This PR introduces a
BatchOpIpldStore
that exposesGetMany
andPutMany
methods. This is for use in parallelForEach
traversal methods for go-hamt-ipld and go-amt-ipld. Actually only theGetMany
method is being used there, but aPutMany
method was added to compliment it. This PR uses theGetMany
blockstore method introduced in ipfs/boxo#492 which, in turn, relies on theTxnDatastore
wrappers introduced in ipfs/go-datastore#210.Parallel go-amt-ipld traversal work that uses this: filecoin-project/go-amt-ipld#84
Parallel go-hamt-ipld traversal work that uses this: filecoin-project/go-hamt-ipld#115
TODO:
Replace replace directives if/when dependencies are merged and released