Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: default to prometheus.DefaultRegisterer #722

Merged
merged 1 commit into from
Nov 27, 2024

refactor: remove prometheus.NewRegistry()

6b292d9
Select commit
Loading
Failed to load commit list.
Merged

refactor: default to prometheus.DefaultRegisterer #722

refactor: remove prometheus.NewRegistry()
6b292d9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 26, 2024 in 0s

60.33% (+0.02%) compared to 8673560

View this Pull Request on Codecov

60.33% (+0.02%) compared to 8673560

Details

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 60.33%. Comparing base (8673560) to head (6b292d9).

Files with missing lines Patch % Lines
gateway/backend_car.go 72.72% 2 Missing and 1 partial ⚠️
gateway/blockstore.go 0.00% 3 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #722      +/-   ##
==========================================
+ Coverage   60.31%   60.33%   +0.02%     
==========================================
  Files         244      244              
  Lines       31034    31036       +2     
==========================================
+ Hits        18717    18725       +8     
+ Misses      10644    10639       -5     
+ Partials     1673     1672       -1     
Files with missing lines Coverage Δ
gateway/metrics.go 82.85% <100.00%> (+0.28%) ⬆️
routing/http/server/server.go 74.57% <100.00%> (+0.26%) ⬆️
gateway/backend_car.go 50.00% <72.72%> (-0.47%) ⬇️
gateway/blockstore.go 0.00% <0.00%> (ø)

... and 14 files with indirect coverage changes