generated from ipfs/ipfs-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provider query manager improvements #716
Open
gammazero
wants to merge
14
commits into
main
Choose a base branch
from
improve-pqm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+302
−170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #716 +/- ##
==========================================
- Coverage 60.43% 60.39% -0.05%
==========================================
Files 243 245 +2
Lines 31059 31111 +52
==========================================
+ Hits 18771 18788 +17
- Misses 10628 10654 +26
- Partials 1660 1669 +9
... and 9 files with indirect coverage changes 🚨 Try these New Features:
|
@gammazero heads up that I'm not looking into this one until #641 is through, at which point it will need to be redone... |
- Replace Debugf with Debugw to avoid unnecessary formatting whn no debug logging. - Use atomic value to protect changable timeout. - Remove inProgressRequestStatuses map when empty. - Do not append to slice forever. Use Deque that reuses items removed from front of slice.
Add configurable options: - WithMaxInProcessRequests - WithMaxProvidersPerFind
gammazero
force-pushed
the
improve-pqm
branch
from
November 22, 2024 21:39
31d3e4d
to
f6d672a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inProgressRequestStatuses
map when empty.WithMaxConcurrentFinds
WithMaxProvidersPerFind