Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bitswap/client/msgq): prevent duplicate requests #691

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(bitswap/client/msgq): prevent duplicate requests #691

wants to merge 2 commits into from
+28 −67

Commits on Oct 29, 2024

  1. fix(bitswap/client/msgq): prevent duplicate requests 

    Previously, in-progress requests could be re-requested again during periodic rebroadcast.
The queue requests, and while awaiting response, the rebroadcast event happens.
Rebroadcast event changes previosly sent WANTs to pending and sends them again in a new message.

The solution here is to ensure WANT was in sent status for long enough, before bringing it back to pending.
This utilizes existing `sendAt` map which tracks when every CID was sent.
    @Wondertan
    Wondertan committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    993c48c View commit details
    Browse the repository at this point in the history

  2. delete absorb as unused

    @Wondertan
    Wondertan committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    a61d89f View commit details
    Browse the repository at this point in the history