examples: verified CAR file fetcher #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacdias
force-pushed
the
example-verified-fetch
branch
4 times, most recently
from
4f713b7 to
1111b82
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #577 +/- ##
==========================================
- Coverage 60.52% 60.11% -0.42%
==========================================
Files 238 236 -2
Lines 29483 23543 -5940
==========================================
- Hits 17844 14152 -3692
+ Misses 10022 7755 -2267
- Partials 1617 1636 +19
|
hacdias
force-pushed
the
example-verified-fetch
branch
2 times, most recently
from
7c9f147 to
8e89cad
Compare
hacdias
force-pushed
the
example-verified-fetch
branch
from
8e89cad to
879dc05
Compare
aschmahmann
requested changes
Mar 26, 2024
hacdias
force-pushed
the
example-verified-fetch
branch
from
879dc05 to
e7f12c8
Compare
hacdias
force-pushed
the
gateway-remote-blocks
branch
from
2036531 to
4bef702
Compare
hacdias
force-pushed
the
example-verified-fetch
branch
2 times, most recently
from
9c31fee to
af564b9
Compare
hacdias
force-pushed
the
example-verified-fetch
branch
from
af564b9 to
21682c3
Compare
hacdias
force-pushed
the
example-verified-fetch
branch
from
21682c3 to
5dd05ed
Compare
lidel
force-pushed
the
example-verified-fetch
branch
from
6c759ea to
d5d4571
Compare
lidel
changed the title
hacdias
force-pushed
the
example-verified-fetch
branch
from
d5d4571 to
140158c
Compare
|
@lidel @aschmahmann I'm mesmerised by how short this code snippet is, and it does more than what we had before. It is stupidly simple and works for both regular files and directories. We already had all the necessary pieces in Boxo. No need to be meddling with |
hacdias
force-pushed
the
example-verified-fetch
branch
2 times, most recently
from
1d8cb34 to
720a4a8
Compare
lidel
approved these changes
May 23, 2024
Comment on lines
+75
to
+85
| // Fetch the file or directory from the gateway. Since we're using a remote CAR | ||
| // backend gateway, this call will internally fetch a CAR file from the remote | ||
| // gateway and ensure that all blocks are present and verified. | ||
| _, file, err := backend.GetAll(context.Background(), imPath) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| defer file.Close() | ||
|
|
||
| // Write the returned UnixFS file or directory to the file system. | ||
| return files.WriteTo(file, outputPath) |
hacdias
force-pushed
the
example-verified-fetch
branch
from
5fbb2d1 to
d3384f3
Compare
wenyue
pushed a commit
to wenyue/boxo
that referenced
this pull request
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple example on how you can use Boxo to verifiably download a file from a trustless gateway. It does not cover the case where we have directories. I think having this, albeit not supporting directories, is better than nothing. With time, we should convert this into its own library module.
Based on #594 to reuse some code.