Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockservice: remove deprecated NewWriteThrough function #565

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Jan 15, 2024

Is it time ?

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b8ac21b) 65.16% compared to head (0536783) 65.47%.

Impacted file tree graph

@@                                 Coverage Diff                                  @@
##           blockservice-stop-using-NewWriteThrough-in-tests     #565      +/-   ##
====================================================================================
+ Coverage                                             65.16%   65.47%   +0.30%     
====================================================================================
  Files                                                   204      207       +3     
  Lines                                                 25597    25621      +24     
====================================================================================
+ Hits                                                  16681    16775      +94     
+ Misses                                                 7433     7366      -67     
+ Partials                                               1483     1480       -3     
Files Coverage Δ
blockservice/blockservice.go 78.23% <ø> (+0.52%) ⬆️

... and 15 files with indirect coverage changes

Base automatically changed from blockservice-stop-using-NewWriteThrough-in-tests to blockservice-opt January 15, 2024 17:20
@Jorropo Jorropo merged commit 3dec443 into blockservice-opt Jan 15, 2024
22 of 23 checks passed
@Jorropo Jorropo deleted the 01-15-blockservice_remove_deprecated_NewWriteThrough_function branch January 15, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants