bitswap: handle dialing to self

ipfs · Nov 19, 2024 · 7359d9f · 7359d9f
1 parent 4ccc944
commit 7359d9f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/bitswap/network/ipfs_impl.go b/bitswap/network/ipfs_impl.go
@@ -359,6 +359,9 @@ func (bsnet *impl) Stop() {
 }
 
 func (bsnet *impl) Connect(ctx context.Context, p peer.AddrInfo) error {
+	if p.ID == bsnet.host.ID() {
+		return nil
+	}
 	return bsnet.host.Connect(ctx, p)
 }
 

diff --git a/routing/providerquerymanager/providerquerymanager.go b/routing/providerquerymanager/providerquerymanager.go
@@ -8,6 +8,7 @@ import (
 	"github.com/ipfs/go-cid"
 	logging "github.com/ipfs/go-log/v2"
 	peer "github.com/libp2p/go-libp2p/core/peer"
+	swarm "github.com/libp2p/go-libp2p/p2p/net/swarm"
 	"go.opentelemetry.io/otel"
 	"go.opentelemetry.io/otel/attribute"
 	"go.opentelemetry.io/otel/trace"
@@ -300,7 +301,7 @@ func (pqm *ProviderQueryManager) findProviderWorker() {
 					defer wg.Done()
 					span.AddEvent("FoundProvider", trace.WithAttributes(attribute.Stringer("peer", p.ID)))
 					err := pqm.dialer.Connect(findProviderCtx, p)
-					if err != nil {
+					if err != nil && err != swarm.ErrDialToSelf {
 						span.RecordError(err, trace.WithAttributes(attribute.Stringer("peer", p.ID)))
 						log.Debugf("failed to connect to provider %s: %s", p.ID, err)
 						return