-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature proposal: testing replace endpoint with the same CID #124
Comments
It sounds like what you want is to update an existing Pin. The spec actually doesn't specify an update method. The So technically, what web3 is doing is to spec. However, I feel like there should be an update method. Otherwise, we have to:
I don't know if we want to use Before updating this, we should get buy-in from all pinning-services and ensure the spec is up to date. Once we do get update functionality, we could add the following checks similar to https://github.com/ipfs-shipyard/pinning-service-compliance/blob/main/src/checks/edit/replacePin.ts
@lidel any thoughts? I also opened ipfs/pinning-services-api-spec#96 in the spec repo. |
|
@lidel i think replace should drop the “required” for CID. As an engineer, that makes it feel like replace is requiring a new CID. If the CID is required, and it’s the same CID, why am i sending it? If its different, i know i need to send it... Otherwise what exactly am i trying to do? |
It should be possible to update a request ID with the same CID using the
POST https://pinning-service.example.com/pins/{requestid}
endpoint, for example when wanting to change thename
,meta
, ororigins
.Currently, web3.storage returns an error when attempting to do that:
{"reason":"PSA_INVALID_DATA","details":"Existing and replacement CID are the same."}
.The text was updated successfully, but these errors were encountered: