It should be possible to update/replace a pin with the same CID

[2color]

There are some cases where it's desired to update the name, meta, and origins fields of a pin request with a given CID using the replace pin endpoint.

Currently, the web3.storage pinning API returns the following 400 error when attempting to update those fields with the same CID.

web3.storage/packages/api/src/pins.js

Lines 253 to 256 in bfa88cb

	const existingCid = existingPinRequest.sourceCid
	if (newPinData.cid === existingCid) {
	throw new PSAErrorInvalidData(INVALID_REPLACE)
	}

Related: ipfs-shipyard/pinning-service-compliance#124

[dchoi27]

cc @mbommerez seems quick to add in the PSA v2 initiative

[mbommerez]

Scenario:

• When you replace a Pin Request with the same CID but different metadata, we get an error.

We need to double check the API spec and try to replicate.

[flea89]

There's some context here...
Wating to get an answer from the team there.
I wonder if we should go ahead anyway and have the replace always return a pin with the same requestid.

[flea89]

Discussed with @olizilla.
We should go ahead and allow for update-like operations but still, keep the behavior consistent with the current implementation and compliance checks here for now.
That means a new pin it's always created and a different requestid is returned by the endpoint.

We can then try to get some alignment and discuss an improved approach in the spec repo with the team.