Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

fix: break graph api notifiers across a sync map #102

Merged
merged 4 commits into from
Apr 26, 2023

Conversation

willscott
Copy link
Collaborator

@willscott willscott commented Apr 25, 2023

Limits how many other exchanges / notifiers are notified.

Aims to fix #92

@willscott willscott requested a review from lidel April 25, 2023 13:50
@willscott willscott force-pushed the fix/lock-granularity branch from 1c8a217 to 02618b6 Compare April 25, 2023 13:53
@lidel
Copy link
Collaborator

lidel commented Apr 25, 2023

@willscott @aarshkshah1992 @aschmahmann @hacdias FYSA
it is now possible to test PRs on staging env without having to merge them to main

I've added support for staging branch – see https://github.com/ipfs/bifrost-gateway#docker, tldr:

When you want to test some code on staging (bifrost-stage1-ny), make sure code is in staging branch (ok to force-push) , docker-image build finished, and then manually ssh to bifrost-stage1-ny and use /data/update-bifrost.sh to deploy version you want. ( staging-latest or staging-YYYY-DD-MM-GITSHA if you want to pin a specific commit)

Demo with this PR:

  1. force-pushed contents of this PR to staging
  2. CI built staging-latest and published it at https://hub.docker.com/r/ipfs/bifrost-gateway/tags
  3. Updated /data/update-bifrost.sh to use staging-latest and run it, you can see it runs the last commit from this PR:
2023/04/25 14:50:40 Starting bifrost-gateway 2023-04-25-8e1661e

@lidel
Copy link
Collaborator

lidel commented Apr 25, 2023

Due to https://github.com/protocol/bifrost-infra/pull/2492 we had to restart the experiment:

2023/04/25 20:14:30 Starting bifrost-gateway 2023-04-25-8e1661e

@aarshkshah1992
Copy link
Collaborator

@lidel Which file should I change if I want to change some environment/config variables for Bifrost ?
When will they get overwritten by CI ?

@willscott
Copy link
Collaborator Author

@aarshkshah1992 https://github.com/protocol/bifrost-infra/blob/master/ansible/inventories/bifrost-gw/group_vars/gateway_bifrost_stage.yml#L43 is probably what you're after?

@lidel lidel changed the title Break graph api notifiers across a sync map fix: break graph api notifiers across a sync map Apr 26, 2023
@lidel
Copy link
Collaborator

lidel commented Apr 26, 2023

@aarshkshah1992 /data/update-bifrost.sh sets values ad-hoc, if you want to keep them around across automated restarts, you need to use file linked by @willscott

Copy link
Collaborator

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR did remove the perf. erosion over ~2h time window described in #92.

We had a pretty long (~12h) window running 8e1661e, and it maintained correctness over time:

2023-04-26_17-19

Let's merge this, so we move focus to the next dragon.
@aschmahmann can revisit this as part of #75

@willscott willscott merged commit 8661352 into main Apr 26, 2023
@willscott willscott deleted the fix/lock-granularity branch April 26, 2023 15:44
@lidel lidel mentioned this pull request Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate why success rate gets worse over time
3 participants