Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/threadsnoop: Add -h option #5134

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

Bojun-Seo
Copy link
Contributor

Import argparser and add basic implementation for this. Now user can use -h option for threadsnoop tool.

Copy link
Contributor

@ekyooo ekyooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about including the tool name in the commit title like the other commits of this project?
"tools/threadsnoop: Add -h..."

Could you also check this in your other commits?

@Bojun-Seo
Copy link
Contributor Author

@ekyooo
Sounds reasonable. I'll change the description and commit message as you suggested. Thanks.

Import argparser and add basic implementation for this. Now user can
use -h option for threadsnoop tool.
@Bojun-Seo Bojun-Seo changed the title tools: Add -h option for threadsnoop tool tools/threadsnoop: Add -h option Nov 8, 2024
@yonghong-song yonghong-song merged commit 2b82d76 into iovisor:master Nov 9, 2024
12 checks passed
@Bojun-Seo Bojun-Seo deleted the threadsnoop branch November 25, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants