Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filters to filetop #5003

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Conversation

Hannibal404
Copy link
Contributor

Add filter to reverse the output order of filetop, and filters to trace either read or write operations at a time

@yonghong-song
Copy link
Collaborator

Could you explain why you add these filters and why they are useful? The existing output should already cover what you try to implement.

@yonghong-song
Copy link
Collaborator

Also, for not-single-character option, please use '--option' format.

@Hannibal404
Copy link
Contributor Author

Could you explain why you add these filters and why they are useful? The existing output should already cover what you try to implement.

The filters implemented allow for finer searching for any files that we need to look for. In case we know the file we are looking for has very few operations, sorting the the reversed order for the same would help. Similarly tracking only read/write operations would help reduce the clutter when a large number of files is there

Also, for not-single-character option, please use '--option' format.

Updated

tools/filetop.py Outdated Show resolved Hide resolved
tools/filetop.py Outdated Show resolved Hide resolved
tools/filetop.py Outdated Show resolved Hide resolved
tools/filetop.py Outdated Show resolved Hide resolved
Signed-off-by: Pradyumn Rahar <[email protected]>
Signed-off-by: Pradyumn Rahar <[email protected]>
@yonghong-song yonghong-song merged commit d53a9c1 into iovisor:master Nov 14, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants