Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add Account address support #979

Merged
merged 19 commits into from
Jan 25, 2024
Merged

Conversation

msarcev
Copy link
Collaborator

@msarcev msarcev commented Jan 18, 2024

Description of change

⚠️ Based on #959 , so it should be merge after that one.

Resolves #885

Type of change

  • Enhancement (a non-breaking change which adds functionality)

Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just small changes required

api/src/services/nova/novaApi.ts Outdated Show resolved Hide resolved
client/src/app/components/nova/OutputView.tsx Outdated Show resolved Hide resolved
client/src/helpers/nova/hooks/useAddressPageState.ts Outdated Show resolved Hide resolved
@msarcev msarcev requested a review from brancoder January 25, 2024 11:33
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@brancoder brancoder merged commit 2462ea3 into nova Jan 25, 2024
3 of 5 checks passed
@brancoder brancoder deleted the feat/account-address-support branch January 25, 2024 11:40
@msarcev msarcev linked an issue Jan 25, 2024 that may be closed by this pull request
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Support address page: Account
2 participants