Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Stardust Genesis Transaction Id #976

Merged
merged 7 commits into from
Jan 22, 2024
Merged

Conversation

brancoder
Copy link
Collaborator

@brancoder brancoder commented Jan 16, 2024

Description of change

Fix link to Stardust Genesis supply increase transactions on Address page and Output page
resolves #917

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member

@VmMad VmMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nice. I'll just leave some refactor comments

@brancoder brancoder requested a review from VmMad January 18, 2024 08:58
Copy link
Member

@VmMad VmMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicts 🙈

@VmMad VmMad requested a review from begonaalvarezd January 22, 2024 09:43
@begonaalvarezd begonaalvarezd merged commit 3389eb2 into dev Jan 22, 2024
5 checks passed
@begonaalvarezd begonaalvarezd deleted the fix/genesis-transaction-id branch January 22, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Fix supply increase stardust genesis outputs marked as chrysalis
4 participants