Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor navbar & add evm explorer links no navbar #970

Merged
merged 12 commits into from
Jan 31, 2024
Merged

feat: refactor navbar & add evm explorer links no navbar #970

merged 12 commits into from
Jan 31, 2024

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented Jan 15, 2024 •
edited
Loading

Description of change

Fixes #961
Fixes #971

Type of change

  • Enhancement
  • Refactor

How the change has been tested

Tested mobile & desktop header + dropdowns + external links

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@VmMad
Copy link
Member Author

VmMad commented Jan 15, 2024 •
edited
Loading

I opened a task to refactor the code in the navbar: #971
Will do it in this PR

@VmMad VmMad self-assigned this Jan 15, 2024
@VmMad VmMad marked this pull request as draft January 22, 2024 11:06
@VmMad VmMad marked this pull request as ready for review January 25, 2024 19:47
@VmMad VmMad requested a review from panteleymonchuk January 26, 2024 09:28
@begonaalvarezd begonaalvarezd dismissed panteleymonchuk’s stale review January 29, 2024 16:12

a new refactor happened after this review

@begonaalvarezd begonaalvarezd changed the title feat: add evm explorer links to the header feat: refactor navbar & add evm explorer links no navbar Jan 31, 2024
@begonaalvarezd begonaalvarezd merged commit f1553db into main Jan 31, 2024
5 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/header/add-evm-explorer branch January 31, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@msarcev msarcev Awaiting requested review from msarcev

@panteleymonchuk panteleymonchuk Awaiting requested review from panteleymonchuk

Assignees

@VmMad VmMad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Refactor Navbar component [Task]: Link EVM explorer
3 participants
@VmMad @begonaalvarezd @panteleymonchuk