Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add build check for pr #969

Merged
merged 4 commits into from
Jan 19, 2024
Merged

ci: add build check for pr #969

merged 4 commits into from
Jan 19, 2024

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented Jan 15, 2024 •
edited
Loading

Description of change

Fixes #944

Type of change

  • Enhancement

How the change has been tested

PR checks.

Change checklist

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@VmMad VmMad self-assigned this Jan 15, 2024
@VmMad VmMad requested a review from panteleymonchuk January 16, 2024 10:55
@msarcev msarcev merged commit e478172 into dev Jan 19, 2024
5 checks passed
@msarcev msarcev deleted the ci/add-build-check branch January 19, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panteleymonchuk panteleymonchuk panteleymonchuk approved these changes

@msarcev msarcev msarcev approved these changes

@begonaalvarezd begonaalvarezd Awaiting requested review from begonaalvarezd

Assignees

@VmMad VmMad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Add build check to the PR CI
3 participants
@VmMad @msarcev @panteleymonchuk