Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove identity resolver from stardust #968

Merged
merged 11 commits into from
Jan 22, 2024

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented Jan 15, 2024

Description of change

Fixes #918

Type of change

Refactor

How the change has been tested

[Describe the tests that you ran to verify your changes.

rms1prkreqc08fsq0dxg6qlnu5u3sjx4z4x0g830kuej8q63s2nnzypsvynznx0 DID tab works ✅
Decentralized Identifier removed ✅

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@VmMad VmMad self-assigned this Jan 15, 2024
client/src/app/components/identity/IdentityChrysalisResolver.scss
client/src/app/components/identity/IdentityChrysalisResolver.tsx
client/src/app/components/identity/IdentityCompareDropdownState.ts
client/src/app/components/identity/IdentityMsgStatusIconProps.ts
@msarcev msarcev requested a review from eike-hass January 17, 2024 09:33
Copy link
Contributor

@eike-hass eike-hass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me!
Is the intention to remove the identity resolver all together for chrysalis networks as well? I was under the impression it was needed to be kept around for legacy chrysalis networks.

@VmMad VmMad marked this pull request as draft January 18, 2024 12:08
@VmMad VmMad marked this pull request as ready for review January 22, 2024 13:16
@VmMad VmMad requested review from eike-hass and msarcev January 22, 2024 13:16
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@begonaalvarezd begonaalvarezd merged commit f26ceb1 into dev Jan 22, 2024
5 checks passed
@begonaalvarezd begonaalvarezd deleted the chore/stardust/remove-identity-resolver branch January 22, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Remove identity resolver utility from stardust networks
3 participants