Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential double loading of identity Wasm #945

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

eike-hass
Copy link
Contributor

@eike-hass eike-hass commented Jan 8, 2024

Description of change

Make sure there is only one instance of the Wasm library initialized even when init is called multiple times.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Stepped through the code locally.

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@eike-hass eike-hass requested a review from abdulmth January 8, 2024 11:30
@begonaalvarezd begonaalvarezd merged commit 1498be6 into dev Jan 18, 2024
3 checks passed
@begonaalvarezd begonaalvarezd deleted the fix/improve-identity-wasm-loading branch January 18, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants