Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Improve stardust Transaction history UX #872

Merged

Conversation

panteleymonchuk
Copy link
Collaborator

Description of change

fixes #857

Type of change

Changing UI

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Check how new UI works on address
http://localhost:3000/mainnet/addr/iota1qrqklnzjwrdp3r8d0t0xff5wtqtpz993rrw5v0ywm6d4z8qlxgw7sp3slr2

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes

Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
@panteleymonchuk panteleymonchuk marked this pull request as ready for review December 6, 2023 11:10
@msarcev msarcev changed the title Change view to date, transactionId, value. Feat: Improve stardust Transaction history UX Dec 6, 2023
@msarcev
Copy link
Collaborator

msarcev commented Dec 6, 2023

npm run lint is failing. Please check and fix the issues.

Additionally i noticed that you name new files with a format that's we didn't use so far in the project. Please keep the naming consistent with how it was done so far. I'm not against this naming format in particular, but we should keep it consistent throught the codebase, whatever it is.

@msarcev
Copy link
Collaborator

msarcev commented Dec 6, 2023

image

Woudl be nice if we could have the table be more "symmetrical" to improve the looks ? The date field seams to take a lot of space, while the transactionId field is "shrinked".

@panteleymonchuk
Copy link
Collaborator Author

@msarcev I can propose this UI.
How it looks for you?
image

Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is looking great 🔥 Added some minor comments and a suggestion we could do on another PR too

Copy link
Collaborator

@msarcev msarcev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As disussed, the tx history list should be displayed up until the last transaction for which we cant know it its complete (unless we reached the end of the chronicle data)

Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to request changes in the previous review 🙈

@panteleymonchuk panteleymonchuk marked this pull request as draft December 29, 2023 21:04
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
@JannemanDev
Copy link

JannemanDev commented Jan 13, 2024

I do not really like the current aligning (nr. 4). Here are the different ways to align (for integers and decimal numbers):

image

I think 6 and 7 are the best looking because of the possibilty of decimal point. Also I suggest the negative (red) and postive (green) colors, or at least different colors to easily differentiate. What do you think?

@panteleymonchuk panteleymonchuk marked this pull request as ready for review January 19, 2024 12:08
@panteleymonchuk
Copy link
Collaborator Author

I do not really like the current aligning (nr. 4). Here are the different ways to align (for integers and decimal numbers):

image

I think 6 and 7 are the best looking because of the possibilty of decimal point. Also I suggest the negative (red) and postive (green) colors, or at least different colors to easily differentiate. What do you think?

I think your suggestion quite reasonable. What I'm not sure about it's a colors. As for colors ok.

Signed-off-by: Eugene Panteleymonchuk <[email protected]>
@begonaalvarezd begonaalvarezd merged commit 0a15fce into dev Jan 19, 2024
5 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/issues-857_improve_readability_of_transactions branch January 19, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Improve readability of Address Transaction History
4 participants