-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Improve stardust Transaction history UX #872
Feat: Improve stardust Transaction history UX #872
Conversation
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
…e_readability_of_transactions
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
client/src/app/components/stardust/history/TransactionHistory.tsx
Outdated
Show resolved
Hide resolved
client/src/app/components/stardust/history/TransactionHistory.tsx
Outdated
Show resolved
Hide resolved
client/src/app/components/stardust/history/TransactionHistory.tsx
Outdated
Show resolved
Hide resolved
client/src/app/components/stardust/history/TransactionHistory.tsx
Outdated
Show resolved
Hide resolved
client/src/app/components/stardust/history/TransactionHistory.tsx
Outdated
Show resolved
Hide resolved
client/src/app/components/stardust/history/TransactionHistory.tsx
Outdated
Show resolved
Hide resolved
Additionally i noticed that you name new files with a format that's we didn't use so far in the project. Please keep the naming consistent with how it was done so far. I'm not against this naming format in particular, but we should keep it consistent throught the codebase, whatever it is. |
@msarcev I can propose this UI. |
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
client/src/app/components/stardust/history/transactionHistoryUtils.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
client/src/app/components/stardust/history/transactionHistoryUtils.ts
Outdated
Show resolved
Hide resolved
client/src/app/components/stardust/history/transactionHistoryUtils.ts
Outdated
Show resolved
Hide resolved
client/src/app/components/stardust/history/transactionHistoryUtils.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is looking great 🔥 Added some minor comments and a suggestion we could do on another PR too
client/src/app/components/stardust/history/TransactionHistory.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As disussed, the tx history list should be displayed up until the last transaction for which we cant know it its complete (unless we reached the end of the chronicle data)
…e_readability_of_transactions
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot to request changes in the previous review 🙈
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
I do not really like the current aligning (nr. 4). Here are the different ways to align (for integers and decimal numbers): I think 6 and 7 are the best looking because of the possibilty of decimal point. Also I suggest the negative (red) and postive (green) colors, or at least different colors to easily differentiate. What do you think? |
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
…e_readability_of_transactions
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
client/src/app/components/stardust/history/transactionHistoryUtils.ts
Outdated
Show resolved
Hide resolved
I think your suggestion quite reasonable. What I'm not sure about it's a colors. As for colors ok. |
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Description of change
fixes #857
Type of change
Changing UI
How the change has been tested
Check how new UI works on address
http://localhost:3000/mainnet/addr/iota1qrqklnzjwrdp3r8d0t0xff5wtqtpz993rrw5v0ywm6d4z8qlxgw7sp3slr2
Change checklist
Add an
x
to the boxes that are relevant to your changes, and delete any items that are not.