Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: basic authentication error with react #1461

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented May 6, 2024

Description of change

Fixes #1460

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

http://example:example@localhost:3000/mainnet

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes

@VmMad VmMad requested review from begonaalvarezd and brancoder May 6, 2024 12:57
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VmMad VmMad requested a review from msarcev May 6, 2024 13:39
@begonaalvarezd begonaalvarezd merged commit 76bb2e5 into main May 6, 2024
6 checks passed
@begonaalvarezd begonaalvarezd deleted the fix/root-auth-error branch May 6, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Fix crashed explorer with basic auth
3 participants