fix: Remove tx inputs sorting by index #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msarcev
added a commit
that referenced
this pull request
Apr 25, 2024
begonaalvarezd
added a commit
that referenced
this pull request
Apr 25, 2024
…1418) * fix: Apply fix for alias reference unlock not pre expanding (issues #1121) to NOVA * feat: Remove preExpandConfig logic around StateController for Nova * feat: Rename function to singular * chore: Apply #1444 fix to Nova (Remove tx inputs sorting by index) --------- Co-authored-by: Begoña Álvarez de la Cruz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR introduces sorting of the INPUTs of a TX payload based on the output (that makes that input on the input side) index, which should not be done because the ordering needs to exactly match the unlocks (sorting on the output side by index is still needed).
Type of change