Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Display account bech32 address instead of account Id #1393

Merged
merged 4 commits into from
Apr 19, 2024
Merged

feat: Display account bech32 address instead of account Id #1393

merged 4 commits into from
Apr 19, 2024

Conversation

msarcev
Copy link
Collaborator

@msarcev msarcev commented Apr 16, 2024 •
edited by begonaalvarezd
Loading

Description of change

Closes #1399

Type of change

  • Enhancement (a non-breaking change which adds functionality)

@msarcev
feat: Display account bech32 address instead of account Id in Block/T…
77cf170 
…ransaction page and Transaction metadata section
@msarcev msarcev linked an issue Apr 16, 2024 that may be closed by this pull request
[Task]: Display account address instead of account ID to improve UX iotaledger/firefly#8339
Closed
@begonaalvarezd begonaalvarezd linked an issue Apr 17, 2024 that may be closed by this pull request
[Task]: Display account address instead of account ID to improve UX #1399
Closed
brancoder
brancoder requested changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Account id is still used on Foundry page. Change the controllerAccountId with controllerAccountBech32 and remove it completely because it looks like its not used anywhere else on the page.

https://github.com/iotaledger/explorer/blob/fix/display-account-address-instead-of-id/client/src/app/routes/nova/FoundryPage.tsx#L116

@msarcev msarcev requested a review from brancoder April 19, 2024 12:20
brancoder
brancoder approved these changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@brancoder brancoder merged commit 10e6e0c into dev Apr 19, 2024
4 of 6 checks passed
@brancoder brancoder deleted the fix/display-account-address-instead-of-id branch April 19, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brancoder brancoder brancoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@msarcev @brancoder