Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Polish Slot Page #1387

Merged
merged 10 commits into from
Apr 22, 2024
Merged

Chore: Polish Slot Page #1387

merged 10 commits into from
Apr 22, 2024

Conversation

brancoder
Copy link
Collaborator

Description of change

closes #1355

Type of change

  • Enhancement (a non-breaking change which adds functionality)

@brancoder brancoder linked an issue Apr 15, 2024 that may be closed by this pull request
2 tasks
@brancoder brancoder requested review from VmMad, msarcev and panteleymonchuk and removed request for VmMad April 19, 2024 10:13
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rmc doesnt match between the feed and the slot page, we should display the exact same information in both places 🙏🏼
image
image

@begonaalvarezd begonaalvarezd merged commit 0de6083 into dev Apr 22, 2024
6 checks passed
@begonaalvarezd begonaalvarezd deleted the chore/polish-slot-page branch April 22, 2024 13:17
const [isFormatBalance, setIsFormatBalance] = useState(true);

const renderValue = () => {
if (truncatedId) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are using PageDataRow only on one page SlotPage.tsx. Do you really need to provide truncatedId and tokenInfo at this point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Polish slots page
3 participants