Feat: Add validators tab to account address page #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msarcev
reviewed
Feb 26, 2024
| @@ -88,6 +93,12 @@ const buildAccountAddressTabsOptions = ( | |||
| isLoading: isCongestionLoading, | |||
| infoContent: bicMessage, | |||
| }, | |||
| [ACCOUNT_TABS.Validation]: { | |||
| disabled: !hasValidatorDetails, | |||
There was a problem hiding this comment.
Maybe we should have stricter criteria for "disabled/hidden" for this one, as it seams like all addresses "have validation details". One the ones i checked it looks like this:
Are cases like this something that we want to show ? @begonaalvarezd
There was a problem hiding this comment.
I dont think it makes sense adding validation tab if the account has no staking feature
…rer into feat/add-validation-tab
begonaalvarezd
approved these changes
Feb 26, 2024
brancoder
added a commit
that referenced
this pull request
Feb 27, 2024
* feat: add output tab to address page * fix: add components to display native tokens * Remove unused code in AddressPageTabbedSections component * remove unused interfaces * Update address states and Add basic outputs API endpoint * Add eslint-disable for unsafe return in novaApiService.ts * Add Foundries tab to Accound address page * Add Foundries tab to Accound address page (#1134) * feat: add block issuance tab to account page * fix: validation check in foundries endpoint * fix: component imports * fix: add is congestion loading * fix: add state tab for Anchor Address * fix: add state metadata feature * feat: add nft section * feat: add nft section + fix:add metadata entries FeaturesView and Asset component * fix: add null checks in BIC section * fix: remove leftover nft metadata property in AddressPageTabbedSection * Feat: Add validators tab to account address page (#1183) * feat: add validators tab to account address page * fix: update sdk commit * fix: show validator tab if account has staking feature * fix: key string --------- Co-authored-by: Mario <[email protected]> Co-authored-by: Begoña Álvarez de la Cruz <[email protected]> --------- Co-authored-by: Mario <[email protected]> Co-authored-by: Begoña Álvarez de la Cruz <[email protected]>
begonaalvarezd
added a commit
that referenced
this pull request
Mar 5, 2024
* feat: add output tab to address page * fix: add components to display native tokens * Remove unused code in AddressPageTabbedSections component * remove unused interfaces * Update address states and Add basic outputs API endpoint * Add eslint-disable for unsafe return in novaApiService.ts * Add Foundries tab to Accound address page * Add Foundries tab to Accound address page (#1134) * feat: add block issuance tab to account page * fix: validation check in foundries endpoint * fix: component imports * fix: add is congestion loading * fix: add state tab for Anchor Address * fix: add state metadata feature * feat: add nft section * feat: add nft section + fix:add metadata entries FeaturesView and Asset component * fix: add null checks in BIC section * fix: remove leftover nft metadata property in AddressPageTabbedSection * feat: add validators tab to account address page * fix: update sdk commit * Add delegation section * fix: show validator tab if account has staking feature * Add fetch delegation ids endpoint * fix: key string * Add hook to fetch delegation outputs * Show delegation outputs total amount * Feat: Add validators tab to account address page (#1183) * feat: add validators tab to account address page * fix: update sdk commit * fix: show validator tab if account has staking feature * fix: key string --------- Co-authored-by: Mario <[email protected]> Co-authored-by: Begoña Álvarez de la Cruz <[email protected]> * add delegation output rewards to Delegation Section * fix: sdk changes to address calculations + styling fix * fix: delegation response types * fix: lint errors --------- Co-authored-by: Mario <[email protected]> Co-authored-by: Begoña Álvarez de la Cruz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
fixes #1082
Type of change
Change checklist