Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add Nft tab #1174

Merged
merged 37 commits into from
Feb 27, 2024
Merged

Feat: Add Nft tab #1174

merged 37 commits into from
Feb 27, 2024

Conversation

brancoder
Copy link
Collaborator

@brancoder brancoder commented Feb 22, 2024 •
edited
Loading

Description of change

sneak fixes:

  • Update MetadataFeature with entries in FeaturesView and Assets components
  • Add null check in AddressBlockIssuaceSection

resolves #1079

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

  • [] My code follows the contribution guidelines for this project
  • [] I have performed a self-review of my own code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes

brancoder and others added 28 commits February 13, 2024 19:38
@brancoder
feat: add output tab to address page
a528704
@brancoder
Merge branch 'dev' into feat/add-outputs-tab
3e24988
@brancoder
fix: add components to display native tokens
aed2313
@brancoder
fix: resolve conflicts
cd0e4ed
@brancoder
Remove unused code in AddressPageTabbedSections component
8ffe165
@brancoder
fix: resolve conflicts
a55715b
@brancoder
fix: resolve confilict
4c9cf07
@brancoder
remove unused interfaces
44fd78a
@brancoder
Update address states and Add basic outputs API endpoint
35d1cbb
@brancoder
Merge branch 'dev' into feat/add-native-tokens-tab
99df7c0
@brancoder
Add eslint-disable for unsafe return in novaApiService.ts
3a10fe5
@brancoder
Add Foundries tab to Accound address page
4027cb5
@brancoder
Add Foundries tab to Accound address page (#1134)
b390f05
@brancoder
feat: add block issuance tab to account page
b77d8a9
@brancoder
fix: validation check in foundries endpoint
0f0b1c5
@brancoder
fix: component imports
9db3390
@brancoder
Merge branch 'dev' into feat/add-native-tokens-tab
1b665f1
@brancoder
fix: resolve conflicts
c77a7ed
@brancoder
fix: add is congestion loading
fa78224
@brancoder
fix: add state tab for Anchor Address
73d5ea0
@brancoder
fix: resolve conflicts
880d17d
@brancoder
Merge branch 'feat/add-bic-tab' into feat/add-state-tab
be4b704
@brancoder
fix: add state metadata feature
1d9ef02
@brancoder
Merge branch 'dev' into feat/add-bic-tab
9d09fc2
@brancoder
fix: conflict resolved
0c5a720
@brancoder
feat: add nft section
3450cba
@brancoder
feat: add nft section + fix:add metadata entries FeaturesView and Ass…
9ffa6b4 
…et component
@brancoder
fix: conflict resolved
fc8fd4c
@brancoder brancoder linked an issue Feb 22, 2024 that may be closed by this pull request
[Task]: Add nft tab to all address pages #1079
Closed
@brancoder brancoder requested a review from msarcev February 22, 2024 14:24
@msarcev
Copy link
Collaborator

msarcev commented Feb 26, 2024

Code looks good. This is not tested though as we don't have any NFTs

brancoder and others added 5 commits February 26, 2024 16:39
@brancoder
Merge branch 'dev' into feat/add-nft-tab
d882fdc
@brancoder
Merge branch 'feat/add-nft-tab' of github.com:iotaledger/explorer int…
c02eef6 
…o feat/add-nft-tab
@brancoder @msarcev @begonaalvarezd
Feat: Add validators tab to account address page (#1183)
2966225 
* feat: add validators tab to account address page

* fix: update sdk commit

* fix: show validator tab if account has staking feature

* fix: key string

---------

Co-authored-by: Mario <[email protected]>
Co-authored-by: Begoña Álvarez de la Cruz <[email protected]>
@brancoder
fix: conflict resolved
25bb7e0
@brancoder
fix: conflict resolved
0ecba7d
@brancoder brancoder merged commit b48ae86 into dev Feb 27, 2024
4 of 6 checks passed
@brancoder brancoder deleted the feat/add-nft-tab branch February 27, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panteleymonchuk panteleymonchuk panteleymonchuk approved these changes

@msarcev msarcev msarcev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Add nft tab to all address pages
3 participants
@brancoder @msarcev @panteleymonchuk